GH-4941: Add batchSize option to RedisItemReader for optimizing N+1 problem using Redis MGET#4942
Open
DevSeongmin wants to merge 1 commit intospring-projects:mainfrom
Open
GH-4941: Add batchSize option to RedisItemReader for optimizing N+1 problem using Redis MGET#4942DevSeongmin wants to merge 1 commit intospring-projects:mainfrom
DevSeongmin wants to merge 1 commit intospring-projects:mainfrom
Conversation
…+1 problem mitigation - Introduced batchSize parameter to RedisItemReader and builder - When batchSize > 1, read keys in batches using Redis MGET - Backward compatible: batchSize = 1 retains existing behavior - Added unit tests covering single and batch modes - Updated Javadoc with usage and limitations Signed-off-by: DevSeongmin <hsm990423@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a
batchSizeparameter toRedisItemReaderand its builder to solve the classic N+1 issue faced during batch reads from Redis.Currently,
RedisItemReaderexecutes individual GET commands per Redis key resulting in a significant number of network round-trips and performance bottlenecks.By enabling batch reading with Redis
MGETwhenbatchSize> 1, this enhancement drastically reduces network calls and improves throughput while maintaining full backward compatibility whenbatchSizeis not set (default = 1).Key Changes
batchSizeproperty with default value1inRedisItemReaderandRedisItemReaderBuilder.batchSize> 1, the reader fetches multiple keys in batch using RedismultiGet()and internally buffers results.batchSize = 1, ensuring no breaking changes.Benefits
Technical Considerations
Related Issue
Fixes #4941
"Terminated by KILL-9 SQUAD 💀"